Hey I'm just getting into really using runspaces to gather information from the network to speed along the process but I'm noticing something intriguing with doubling up of information so I have a few questions about the script I'm using, in hopes you lovely
people can help clarify things I'm clearly not understanding.
Apologies the script has gotten a little dirty as I'm trying to break it apart and test sections.
Question 1: the "$RunspacePool = [runspacefactory]::CreateRunspacePool(1,$breakdown)" would work out to say (1,4) variable my understanding is that should mean maximum threads of 4? however I notice the chunk is actually 5 threads,
if I up the count its always 1 more and I'm not sure why.
Question 2: I noticed the last thread double ups on me if I were to run the below script against 20 PCs and expect results like:
Machine Username
Disabled
Computer1 Administrator Active
Computer1 Guest Disabled
Computer2 Administrator Active
Computer2 Guest Disabled
Computer3 Administrator Active
Computer3 Guest Disabled
Computer4 Administrator Active
Computer4 Guest Disabled
Computer5 Administrator Active
Computer5 Guest Disabled
but instead I'll get the results of:
Machine Username Disabled
Computer1 Administrator Active
Computer1 Guest Disabled
Computer2 Administrator Active
Computer2 Guest Disabled
Computer3 Administrator Active
Computer3 Guest Disabled
Computer4 Administrator Active
Computer4 Guest Disabled
Computer2 Administrator Active
Computer2 Guest Disabled
Computer5 Administrator Active
Computer5 Guest Disabled
noting that the last thread runs again on a previously used thread and has the previously collated data still within in it to return. also thing to note when the script runs the next chunk despite the:
$jobs[$jobstart].PowerShell.Dispose()
$jobs[$jobstart].powershell = $null
$jobs[$jobstart].handle = $null
and
$jobs.clear()
$jobs = $null
lines let alone the $job variable being re declared I notice each thread is still retaining the previously returned information from prior jobs. how can I clear this so the threads do not retain or return the previous information again without having
to "unique" the results table after the fact.
Example Script:
$Computers = Get-ADComputer -Filter * -Properties lastLogonTimestamp, operatingsystem, servicePrincipalName | ?{$_.enabled -eq $true} | ?{($_.servicePrincipalName -join "-") -notlike "*clustervirtual*"}
$breakdown = [int]$env:NUMBER_OF_PROCESSORS
$runner = $Computers.Count
$num1 = 0
$num2 = $breakdown
$check = 0
$Results =$null
#region Runspace Pool
[runspacefactory]::CreateRunspacePool()
$SessionState = [System.Management.Automation.Runspaces.InitialSessionState]::CreateDefault()
$RunspacePool = [runspacefactory]::CreateRunspacePool(1,$breakdown)
$PowerShell = [powershell]::Create()
$PowerShell.RunspacePool = $RunspacePool
$RunspacePool.Open()
#endregion
do{
write-host "running block $num1..$num2 out of $runner" -ForegroundColor green
$jobs = New-Object System.Collections.ArrayList
$count = 1
ForEach($Computer in $Computers[$num1..$num2]){
$Parameters = @{
Computer = $computer
}
$PowerShell = [powershell]::Create()
$PowerShell.RunspacePool = $RunspacePool
[void]$PowerShell.AddScript({
Param ($computer)
run custom script
return $Report
})
[void]$PowerShell.AddParameters($Parameters)
$Handle = $PowerShell.BeginInvoke()
$temp = '' | Select PowerShell,Handle
$temp.PowerShell = $PowerShell
$temp.handle = $Handle
[void]$jobs.Add($Temp)
}
$waittimer = 0
do{
if($jobs.handle.IsCompleted -like $false){
Write-Host "." -NoNewline
Start-Sleep -Seconds 1
$waittimer++}ELSE{$waittimer = 100}
}until($waittimer -eq 100)
$jobs = $jobs| ?{$_.handle.IsCompleted -like $true}
$jobcount = $jobs.Count
$jobstart = 0
do{
if($jobstart -lt $jobcount-1){
$Results += $jobs[$jobstart].powershell.EndInvoke($jobs[$jobstart].handle)
$jobs[$jobstart].PowerShell.Dispose()
$jobs[$jobstart].powershell = $null
$jobs[$jobstart].handle = $null
}ELSE{
$Results += $jobs[$jobstart].powershell.EndInvoke($jobs[$jobstart].handle) | ?{$_.machinename -like (($jobs[$jobstart].powershell.EndInvoke($jobs[$jobstart].handle) | select Machinename -Unique)[1]).machinename}
$jobs[$jobstart].PowerShell.Dispose()
$jobs[$jobstart].powershell = $null
$jobs[$jobstart].handle = $null
}
$jobstart++
}until($jobstart -eq $jobcount)
$jobs.clear()
$jobs = $null
$num1 = $num1+$breakdown+1
$num2 = $num2+$breakdown+1
if($num2 -ge $runner){$num2 = $runner
$check++}
}until($check -gt 1)
$RunspacePool.Close()
New-TimeSpan -Start $start -End (get-date)
