locked
Feedback wanted: Behind the Scenes of the Data Privacy Firewall RRS feed

  • General discussion

  • Hi all,

    Happy Friday! Here's some light weekend reading for all you forum-dwellers who want to know more about how PQ works behind the scenes. I've been working on this for a while now, and I'd love to hear your feedback on it.

    Ehren

    - - - - - - - - -

    Microsoft Power Query

    Behind the Scenes of The Data Privacy Firewall

    Last Updated March 1st, 2019

    If you’ve used Power Query for any length of time, you’ve likely experienced it. There you are, happily querying away, when you suddenly get an error that no amount of online searching, query tweaking, or keyboard bashing can remedy. An error like:

    Formula.Firewall: Query 'Query1' (step 'Source') references other queries or steps, so it may not directly access a data source. Please rebuild this data combination.

    Or maybe:

    Formula.Firewall: Query 'Query1' (step 'Source') is accessing data sources that have privacy levels which cannot be used together. Please rebuild this data combination.

    These Formula.Firewall errors are the result of Power Query’s Data Privacy Firewall (aka the Firewall), which at times may seem like it exists solely to frustrate data analysts the world over. Believe it or not, however, the Firewall serves an important purpose. In this article, we’ll delve under the hood to better understand how it works. Armed with greater understanding, you will hopefully be able to better diagnose and fix Firewall errors in the future.

    What is it?

    The purpose of the Data Privacy Firewall is simple: it exists to prevent Power Query from unintentionally leaking data between sources.

    Why is this needed? I mean, you could certainly author some M that would pass a SQL value to an OData feed. But this would be intentional data leakage. The mashup author would (or at least should) know they were doing this. Why then the need for protection against unintentional data leakage?

    The answer? Folding.

    Folding?

    Jokes about laundry aside, “folding” is a term that refers to converting expressions in M (such as filters, renames, joins, etc.) into operations against a raw data source (such as SQL, OData, etc.). A huge part of Power Query’s power comes from the fact that PQ can convert the operations a user performs via its UI into complex SQL or other backend data source languages, without the user having to know said languages. Users get the performance benefit of native data source operations, with the ease of use of a UI where all data sources can be transformed using a common set of commands.

    As part of folding, PQ sometimes may determine that the most efficient way to execute a given mashup is to take data from one source and pass it to another. For example, if you’re joining a small CSV file to a huge SQL table, you probably don’t want PQ to read the CSV file, read the entire SQL table, and then join them together on your local computer. You probably want PQ to inline the CSV data into a SQL statement and ask the SQL database to perform the join.

    This is how unintentional data leakage can happen.

    Imagine if you were joining SQL data that included employee Social Security Numbers with the results of an external OData feed, and you suddenly discovered that the Social Security Numbers from SQL were being sent to the OData service. Bad news, right?

    This is the kind of scenario the Firewall is intended to prevent.

    How does it work?

    The Firewall exists to prevent data from one source from being unintentionally sent to another source. Simple enough.

    So how does it accomplish this mission?

    It does this by dividing your M queries into something called partitions, and then enforcing the following rule:

    A partition may either access compatible data sources, or reference other partitions, but not both.

    Simple…yet confusing. What’s a partition? What makes two data sources “compatible”? And why should the Firewall care if a partition wants to access a data source and reference a partition?

    Let’s break this down and look at the above rule one piece at a time.

    What’s a partition?

    At its most basic level, a partition is just a collection of one or more query steps. The most granular partition possible (at least in the current implementation) is a single step. The largest partitions can sometimes encompass multiple queries. (More on this later.)

    If you’re not familiar with steps, you can view them on the right of the Power Query Editor window after selecting a query, in the Applied Steps pane. Steps keep track of everything you’ve done to transform your data into its final shape. (Then again, if you’re not familiar with steps, what in the world are you doing reading an article like this?)

    Partitions that reference other partitions

    When a query is evaluated with the Firewall on, the Firewall divides the query and all its dependencies into partitions (i.e. groups of steps). Any time one partition references something in another partition, the Firewall replaces the reference with a call to a special function called Value.Firewall. In other words, the Firewall doesn’t allow partitions to access each other willy-nilly. All references are modified to go through the Firewall. Think of the Firewall as a gatekeeper. A partition that references another partition must get the Firewall’s permission to do so, and the Firewall controls whether or not the referenced data will be allowed into the partition.

    This all may seem pretty abstract, so let’s look at an example.

    Assume we have a query called Employees, which pulls some data from a SQL database. Assume we also have another query (EmployeesReference), which simply references Employees.

    shared Employees = let
        Source = Sql.Database(…),
        EmployeesTable = …
    in
        EmployeesTable;

    shared EmployeesReference = let
        Source = Employees
    in
        Source;

    These queries will end up divided into two partitions: one for the Employees query, and one for the EmployeesReference query (which will reference the Employees partition). When evaluated with the Firewall on, these queries will be rewritten like so:

    shared Employees = let
        Source = Sql.Database(…),
        EmployeesTable = …
    in
        EmployeesTable;

    shared EmployeesReference = let
        Source = Value.Firewall("Section1/Employees")
    in
        Source;

    Notice that the simple reference to the Employees query has been replaced by a call to Value.Firewall, which is provided the full name of the Employees query.

    When EmployeesReference is evaluated, the call to Value.Firewall("Section1/Employees") is intercepted by the Firewall, which now has a chance to control whether (and how) the requested data flows into the EmployeesReference partition. It can do any number of things: deny the request, buffer the requested data (which prevents any further folding to its original data source from occurring), and so on.

    This is how the Firewall maintains control over the data flowing between partitions.

    Partitions that directly access data sources

    Let’s say we define a query Query1 with one step (note that this single-step query will correspond to one Firewall partition), and that this single step accesses two data sources: a SQL database table and a CSV file. How does the Firewall deal with this, since there’s no partition reference, and thus no call to Value.Firewall for it to intercept? Let’s review to the rule stated earlier:

    A partition may either access compatible data sources, or reference other partitions, but not both.

    In order for our single-partition-but-two-data-sources query to be allowed to run, its two data sources must be “compatible”. In other words, it needs to be okay for data to be shared between them. In terms of the Power Query UI, this means the Privacy Levels of the SQL and CSV data sources need to both be Public, or both be Organizational. If they are both marked Private, or one is marked Public and one is marked Organizational, or they are marked using some other combination of Privacy Levels, then it is not safe for them to both be evaluated in the same partition. Doing so would mean unsafe data leakage could occur (due to folding), and the Firewall would have no way to prevent it.

    What happens if you try to access incompatible data sources in the same partition?

    Formula.Firewall: Query 'Query1' (step 'Source') is accessing data sources that have privacy levels which cannot be used together. Please rebuild this data combination.

    Hopefully you now better understand one of the error messages listed at the beginning of this article.

    Note that this “compatibility” requirement only applies within a given partition. If a partition is referencing other partitions, the data sources from the referenced partitions do not have to be compatible with one another. This is because the Firewall can buffer the data, which will prevent any further folding against the original data source. The data will be loaded into memory and treated as if it came from nowhere.

    Why not do both?

    Let’s say we define a query with one step (which will again correspond to one partition) that accesses two other queries (i.e. two other partitions). What if we wanted, in the same step, to also directly access a SQL database? Why can’t a partition reference other partitions and directly access compatible data sources?

    As we saw earlier, when one partition references another partition, the Firewall acts as the gatekeeper for all the data flowing into the partition. To do so, it must be able to control what data is allowed in. If there are data sources being accessed within the partition, as well as data flowing in from other partitions, it loses its ability to be the gatekeeper, since the data flowing in could be leaked to one of the internally accessed data sources without it knowing about it. Thus the Firewall prevents a partition that accesses other partitions from being allowed to directly access any data sources.

    So what happens if a partition tries to reference other partitions and also directly access data sources?

    Formula.Firewall: Query 'Query1' (step 'Source') references other queries or steps, so it may not directly access a data source. Please rebuild this data combination.

    Now you hopefully better understand the other error messages listed at the beginning of this article.

    Partitions in-depth

    As you can probably guess from the above information, how queries are partitioned ends up being incredibly important. If you have some steps that are referencing other queries, and other steps that access data sources, you now hopefully recognize that drawing the partition boundaries in certain places will cause Firewall errors, while drawing them in other places will allow your query to run just fine.

    So how exactly do queries get partitioned?

    This section is probably the most important for understanding why you’re seeing Firewall errors, as well as understanding how to resolve them (where possible).

    Here’s a high-level summary of the partitioning logic.

    • Initial Partitioning
      • Creates a partition for each step in each query
    • Static Phase
      • This phase doesn’t depend on evaluation results. Instead, it relies on how the queries are structured.
      • Parameter Trimming
        • Trims parameter-esque partitions, i.e. any one that:
          • Doesn’t reference any other partitions
          • Doesn’t contain any function invocations
          • Isn’t cyclic (i.e. it doesn’t refer to itself)
        • Note that “removing” a partition effectively includes it in whatever other partitions reference it.
        • Trimming parameter partitions allows parameter references used within data source function calls (e.g. Web.Contents(myUrl)) to work, instead of throwing “partition can’t reference data sources and other steps” errors.
      • Grouping (Static)
        • Partitions are merged, while maintaining separation between:
          • Partitions in different queries
          • Partitions which reference other partitions vs. those that don’t
    • Dynamic Phase
      • This phase depends on evaluation results, including information about data sources accessed by various partitions.
      • Trimming
        • Trims partitions that meet all the following requirements:
          • Doesn’t access any data sources
          • Doesn’t reference any partitions that access data sources
          • Isn’t cyclic
      • Grouping (Dynamic)
        • Now that unnecessary partitions have been trimmed, try to create Source partitions that are as large as possible.
        • Merge all partitions with their input partitions if each of its inputs:
          • Is part of the same query
          • Doesn’t reference any other partitions
          • Is only referenced by the current partition
          • Isn’t the result (i.e. final step) of a query
          • Isn’t cyclic

    What in the world does all this mean?

    Let’s walk through an example to illustrate how the complex logic laid out above works.

    Here’s our sample scenario. It’s a fairly straightforward merge of a text file (Contacts) with a SQL database (Employees), where the SQL server is a parameter (DbServer).

    Goldilocks and the three queries

    Here’s the M code for the three queries used in this example.

    shared DbServer = "montegoref6" meta [IsParameterQuery=true, Type="Text", IsParameterQueryRequired=true];


    shared Contacts = let

        Source = Csv.Document(File.Contents("C:\contacts.txt"),[Delimiter="   ", Columns=15, Encoding=1252, QuoteStyle=QuoteStyle.None]),

        #"Promoted Headers" = Table.PromoteHeaders(Source, [PromoteAllScalars=true]),

        #"Changed Type" = Table.TransformColumnTypes(#"Promoted Headers",{{"ContactID", Int64.Type}, {"NameStyle", type logical}, {"Title", type text}, {"FirstName", type text}, {"MiddleName", type text}, {"LastName", type text}, {"Suffix", type text}, {"EmailAddress", type text}, {"EmailPromotion", Int64.Type}, {"Phone", type text}, {"PasswordHash", type text}, {"PasswordSalt", type text}, {"AdditionalContactInfo", type text}, {"rowguid", type text}, {"ModifiedDate", type datetime}})

    in

        #"Changed Type";


    shared Employees = let

        Source = Sql.Databases(DbServer),

        AdventureWorks = Source{[Name="AdventureWorks"]}[Data],

        HumanResources_Employee = AdventureWorks{[Schema="HumanResources",Item="Employee"]}[Data],

        #"Removed Columns" = Table.RemoveColumns(HumanResources_Employee,{"HumanResources.Employee(EmployeeID)", "HumanResources.Employee(ManagerID)", "HumanResources.EmployeeAddress", "HumanResources.EmployeeDepartmentHistory", "HumanResources.EmployeePayHistory", "HumanResources.JobCandidate", "Person.Contact", "Purchasing.PurchaseOrderHeader", "Sales.SalesPerson"}),

        #"Merged Queries" = Table.NestedJoin(#"Removed Columns",{"ContactID"},Contacts,{"ContactID"},"Contacts",JoinKind.LeftOuter),

        #"Expanded Contacts" = Table.ExpandTableColumn(#"Merged Queries", "Contacts", {"EmailAddress"}, {"EmailAddress"})

    in

        #"Expanded Contacts";


    Here’s a higher-level view, showing the dependencies.

    Query Dependencies Dialog


    Let’s Party Partition!

    Let’s zoom in a bit and include steps in the picture, and start walking through the partitioning logic. Here’s a diagram of our three queries, showing the initial firewall partitions in green. Notice that each step starts in its own partition.


    Next, we trim parameter partitions. Thus, DbServer gets implicitly included in the Source partition.


    Now we perform the static grouping. This maintains separation between partitions in separate queries (note for instance that the last two steps of Employees don’t get grouped with the steps of Contacts), as well as between partitions that reference other partitions (such as the last two steps of Employees) and those that don’t (such as the first three steps of Employees).



    Now we enter the dynamic phase. In this phase, the above static partitions are evaluated. Partitions that don’t access any data sources are trimmed. Partitions are then grouped to create source partitions that are as large as possible. However, in this sample scenario, all the remaining partitions access data sources, and there isn’t any further grouping that can be done. The partitions in our sample thus won’t change during this phase.

    Let’s Pretend…

    For the sake of illustration, though, let’s look at what would happen if the Contacts query, instead of coming from a text file, were hard-coded in M (perhaps via the “Enter Data” dialog).

    In this case, the Contacts query would not access any data sources. Thus, it would get trimmed during the first part of the dynamic phase.



    With the Contacts partition removed, the last two steps of Employees would no longer reference any partitions except the one containing the first three steps of Employees. Thus, the two partitions would be grouped.

    The resulting partition would look like this.


    That’s a wrap

    While there is much more that could be said on this topic, this introductory article is already long enough. Hopefully it’s given you a better understanding of the Firewall, and you better be able to understand and fix Firewall errors when you encounter them in the future. Happy querying!





    Friday, March 1, 2019 11:46 PM

All replies

  • 
    Saturday, March 2, 2019 2:54 AM
  • The common scenario of the user persona is that they get this when doing either one of these things:

    • A merge / combine / append operation (as showcased in your example)
    • Using a Parameter from an Excel table (also kind of showcased in the example!)

    From my personal experience, I just explain it how Curt mentioned a few years ago in a blog post (I think it was 2015) on how the Static phase worked and kinda still works in the service where it simply scans your code and when it finds out that a Data Source function doesn't have explicitly the argument that it needs, just a parameter / variable / query name attached to it, it won't "resolve". Kind of how a DNS can't resolve a specific url domain to a specific ip address unless it's correctly configured.

    While it would be pretty cool to have a catalog of every possible situation that could potentially happen, similar to how you've listed the errors and what usually triggers them, there are some exceptions that drove me nuts in the past. For instance, use the MailChimp connector and set 2 different queries with it - perhaps one is a list of your contacts and the other one is the activity log of each of your contacts. When you try combining those 2 it gives you an error :( a Formula Firewall error. The connector is a singleton, yet it can't combine data with itself?

    This post couldn't have come in a more perfect timing. I'm currently working on a blog post about this - I've been building up to it since the start of the year lol.

    Anyway, in terms of feedback:

    • Add like a disclaimer that these are just some guidelines and not every situation is the same. It's more of a guidebook on how to audit and figure out what's going on
    • Not sure if this is the current plans, but it would be amazing to expose that process in the error message or some sort of developer tool to debug those situations and figure out exactly what's causing it. It gets terrible when someone sends you a workbook with 5891285912898 queries and you need to basically spend your whole night investigating it
    • I posted an image earlier to make the process / stages more visual. I'm the type of guy that loves a good diagram.
    Saturday, March 2, 2019 3:08 AM
  • Hi Ehren,

    First of all, thank you for taking the time to write this up. This kind of detailed information is really, really important for us to understand what's going on inside the Power Query engine!

    Secondly, when the article is ready, can I suggest you start a blog to share it? There's so much useful information that is buried in posts on this forum and a blog would make it all much easier to find.

    Regarding the article itself I'm still trying to understand it all properly so I don't think I can provide much feedback on what's there. However there is something missing, and it would be great to have this added to the current article or in a follow-up: almost everyone looking for information on this topic is trying to make their query refresh and getting one of the error messages you mention, so it would be great if you could include a few examples of:

    • Queries that are returning firewall errors, showing how to rewrite them to avoid the errors and explaining why the rewrite makes a difference
    • Queries that are slow because of the firewall, showing how to rewrite them to get better performance and again explaining why the rewrite makes a difference

    Finally, as Miguel said, any tooling you can provide that will help us understand where partition boundaries lie and what the firewall does on partition boundaries will be incredibly useful - even if this is just something in a diagnostic log file.

    Thanks,

    Chris


    Check out my MS BI blog I also do SSAS, Power BI, MDX, DAX and M consultancy

    Sunday, March 3, 2019 10:41 PM
  • Hi Ehren,

    thanks so much for this detailed write up. As Miguel and Chris said, that's really important information!

    Haven't read thoroughly yet, but second the above suggestions.

    Thx, Imke


    Imke Feldmann - MVP Data Platform (PowerBI) - http://www.TheBIccountant.com 

    Please use the 'Mark as answer' link to mark a post that answers your question. If you find a reply helpful, please remember to vote it as helpful - Thanks!

    Monday, March 4, 2019 2:42 PM
  • Hi Ehren, Very helpful explanations. A possible improvement could be to also include one or more process flow diagrams with abstract steps/stages and the logical branches. Basically a hybrid between the applied step diagrams that you’ve already provided and the diagram in Miguel’s reply :)

    Regards,

    Michael Amadi

    Please use the 'Mark as answer' link to mark a post that answers your question. If you find a reply helpful, please remember to vote it as helpful :)

    Website: http://www.nimblelearn.com, Twitter: @nimblelearn

    Monday, March 4, 2019 9:53 PM
  • Hi Ehren,

    Thanks for the detailed write-up here.  As Miguel, Chris & Imke has already stated, this is super useful.  This has always been a bit of a nebulous feature to me, and I'm glad to see some light shed on it.  It's going to take a couple more read-throughs (at least) before it all sinks in though.

    The one thing that is missing for me is the method on how to actually combine the data sources you showed without triggering the firewall error.  The reality most of us face is that re-coding the CSV in M code isn't really a practical solution.  We get what we get and need to find a way to combine it, then have it refresh in Power BI where we can't just disable the firewall.

    I'd love to see you show an alternate version of your evaluation that splits the Employees table right before the Merged Queries step.  Does that fix it, or do you need to leverage Table.Buffer to force the folding to stop, or...?  It's this kind of walk through that will be essential to new/intermediate users to actually solve the issue, rather than just identify it.


    Ken Puls, CMA, MS MVP(Excel) I hate it when my computer does what I tell it to and not what I want it to...

    Friday, March 8, 2019 12:56 AM
  • Hi all,

    Thanks for the feedback. I agree that some before/after examples of how to resolve common error cases would be helpful. Maybe that can be Part II...

    Ken, one clarification: the example above where I switch from a text file to M literals is not meant as an error resolution example. Both of these scenarios (text file and M literals) work fine with the Firewall on. The reason for the switch to M literals was simply to illustrate phases of the partitioning logic that otherwise wouldn't have any effect.

    Ehren

    Monday, March 11, 2019 10:49 PM
  • Hi Ehren!

    Thanks a lot for the great info! Hopefully the next parts of the saga will be done as well.

    I have questions

    1. You told that Contacts would be trimmed if it would be hardcoded. But it means that "Merged Queries" step of Employees query would end up with an error? Or you mean something else but not just "not using trimmed code at all during execution of the query", when you say "trim"?

    2. How custom functions are treated in all that logic? They do not access any specific sources, but they are Queries from PQ UI point of view...

    3. And how all the logic of _trimming_ works, if I define a function as a record field, then write it into a field (of record or table), and then call it ONLY as value of a field? I.e.:

    let r = [f = (x) => x], t = #table({"w"}, {{r[f]}}) in t{0}[w](1)

    Does "trimming" mean that such a function will be killed (trimmed) at the moment of query execution, and the query will end up with an error?

    3.1. And what about this variant:

    let r = [f = (x) => x], t = #table({"w"}, {{Record.Field(r, "f")}}) in t{0}[w](1)

    Just in case - for me all that are real things, I'd like to use them and see their real value for my current projects.

    4. What about Excel? Is the logic, described in the article, the same, or some details are different? As for trimming logic, I see some differences with handling at least #shared & #sections...

    5. What is the logic of Firewall / Trimming of Queries, defined through Expression.Evaluate(…, #shared / #section[Section1])?

    Sunday, July 7, 2019 9:37 PM
  • Hi Andrey. I think you're getting confused by the terminology. In the context of the firewall, the only "trimming" that occurs involves removing firewall partitions (which you can think of as boxes around certain sets of M steps). It seems like you're asking about the trimming that takes place during load in PBIDesktop, where we remove the M for unused queries. This is completely different, and I'll reply regarding this second kind of trimming on the other thread you started.

    Ehren

    Monday, July 8, 2019 7:21 PM
  • Ehren, thanks a lot for your answer. And what about these questions:

    2. How custom functions are treated by Firewall? They do not access any specific sources, but they are Queries from PQ UI point of view...

    4. What about Excel? Is the logic, described in the article, the same?

    5. Is the logic of Firewall of Queries, defined through Expression.Evaluate(…, #shared / #section[Section1]), the same?

    Tuesday, July 9, 2019 8:26 AM
  • Hi Ehren,

    I've just re-read the article, but still having a hard time to understand why this query throws this error: 

    "'Transform all other elements' (step 'StartWithEmptyTable') references other queries or steps, so it may not directly access a data source"

    let
        Source = StagingOthers,
        QueryParameter = Table.Buffer(Table.FromRecords({ [Query=[offset=Text.From(Source[offset]), limit=Text.From(Source[limit])]] } )),
        StartWithEmptyTable = Json.Document(Web.Contents("https://pokeapi.co/api/v2/ability", Table.ToRecords(QueryParameter){0}))
    in
        StartWithEmptyTable
    The only dynamic element are the query parameters coming from "StagingOthers". But I'd think that this is a separate partition and should therefore work? I've even tried to help with manual buffering, but no effect.

    As this is a paging query, the Source for the parameters from "StagingOthers" comes from the same data source. So I thought that the fact that those permissions are only set once could be the problem. But this didn't seem to be the case: After some code adjustment I managed to get 2 different data sources and set them both to public:

    Still, same error.
    Do you have any hint for me what I can try to make this work?

    Thanks!


    Imke Feldmann - MVP Data Platform (PowerBI) - http://www.TheBIccountant.com 

    Please use the 'Mark as answer' link to mark a post that answers your question. If you find a reply helpful, please remember to vote it as helpful - Thanks!

    Sunday, April 26, 2020 6:03 AM
  • Thaks Ehren (and Chriss for your excelent video at London user group for more than a year agao). After understanding this (I think), and doing some tests, my conclusion is that the partition mechanism in power query is wrong (or kind of lazy).

    Please read this since I think there's both a big potential to speed up the queries as well as a big potential to get rid of some none needing partitions.

    The problem with the partitioning is that it doesn't adhere to the behavior of none loading queries. I have seen the same where it comes to refresh policies in Power BI Dataflows, and now I see the same for partitions.

    None loading queries and none loading standard entities in Power BI dataflow are for me just sub-queries with M-code. Although I might be naïve here, I think it's a valid comparation in this case.

    So what's the problem:
    The problem is that when you refer to a none loading query there's no need to keep the partition, in the end it's just M-code borrowed from the referenced query. 

    Looking at the query dependencies below I have two queries doing the same thing but in different ways.

    Some words about what we see above, or more specifically what we don't see... The query dependency view in Power Query has some faults, so we don't see everything, and I will explain

    1. The database and server labels are also used by the query "test2", but as you will see in the code section below, they are used in a subsection encapsulated in a let/in section and thereby not visible (yet another problem with how sub-queries are treated in Power Query).
    2. Both "test" and "test2" are configured to be loaded queries, but since we have a fault on "test", the queries are not loaded into the data model. Looks like the Power Query "Query dependencies" doesn't use the metadata for if a query shall be loaded or not, rather it checks if the query has been loaded into the model or not. This is not as server as (2) though, and might be by design requirements

    So what we have is a none loading query "pri" that is referenced by the "test" query. I also have a function that for each row in the pri-table, counts the matching rows in an other table from the same data source, and I finally use that function to add a column in the "test" query. The result is expected to look like this:

    If we check the partitions with the diagnostic tool (great tool by the way), we can see that there are two partitions active in the "test" query. One from the referring query "pri", and one created for the Table.AddColumn() step. Then according to the rules, we do break the law...

    The code involved look like this:

    shared FnRowsInFact = (priority as any) as number => 
    let
        Source = Sql.Database(server, database),
        Navigation = Source{[Schema="dbo",Item="call_req"]}[Data],
        #"Filtered Rows" = Table.SelectRows(Navigation, each ([priority] = priority)),
        #"Counted Rows" = Table.RowCount(#"Filtered Rows")
    in
        #"Counted Rows";
    
    shared pri = let
      Source = Sql.Database(server, database),
      Navigation = Source{[Schema="dbo",Item="pri"]}[Data],
      #"Removed Other Columns" = Table.SelectColumns(Navigation,{"enum", "nx_desc"})
    in
      #"Removed Other Columns";
    
    shared test = let
        Source = pri,
        #"Invoked Custom Function" = Table.AddColumn(Source, "FnRowsInFact", each FnRowsInFact([enum]))
    in
        #"Invoked Custom Function";

    Since the partition coming from the none loading "pri" query is just a sub query, there are no need to maintain that partition! This can easily be proved by replacing the code referring to the "pri" query with the steps from the "pri" query itself. This can be done by either adding the steps one by one, or by adding the whole query as a sub-query, and the last thing I did in the query "test2" as you can see below

    To exemplify this, I created as second query called "test2" by simply duplicating the "test2" query. Within the newly created "test2" query, I replace the code for 

    shared test2 = let
      Source = 
        let
          Source                   = Sql.Database(server, database),
          Navigation               = Source{[Schema = "dbo", Item = "pri"]}[Data],
          #"Removed Other Columns" = Table.SelectColumns(Navigation, {"enum", "nx_desc"})
        in
          #"Removed Other Columns",
      #"Invoked Custom Function" = Table.AddColumn(Source, "FnRowsInFact", each FnRowsInFact([enum]))
    in
      #"Invoked Custom Function";

    And as can bee seen, the "test2" query will load just fine and have no problem with the formula engine.

    Soo... To summarize what's needed from the Microsoft Power Query team to do. There's a need to recursively walk through all references queries that are none loading before setting up the partition schema. This will both improve the query performance for everyone, not just the one having problems with getting though the formula engine, but also let more people through the formula firewall in a legitim way.

    And as we could see in the query dependencies view, Microsoft also need to do the same recursive walk even when showing the dependency diagram or these diagrams will not show the right thing. This also goes for the dependencies for Power BI dataflows. For these I have an ongoing ticket. But the main concerns with this is that it also effects the query chain where none loading linked entities (in reality they are transformed to none loading standard entities) does not follow the refresh dependencies for premium capacities.

    I really hope this is picked up and that we can have a change in the feature.

    Friday, October 2, 2020 11:21 AM
  • Friday, October 2, 2020 11:53 AM